Add "webrick" to Gemfile #2120
Merged
Add "webrick" to Gemfile #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Ruby 3.0 webrick is no longer part of the Ruby standard library: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/ Adding it for Ruby 2 in the "test" section should be fine also. A recent update happened to add webrick to the Gemfile.lock indirectly, when "yard" was updated since the new version of yard requires webrick. But it's probably worth adding webrick to the Gemfile explicitly since we depend on it for tests, not just for yard.
jordan-brough
force-pushed
the
webrick-dependency
branch
from
91f0c96 to
88d6f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Ruby 3.0 webrick is no longer part of the Ruby standard library:
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Adding it for Ruby 2 in the "test" section should be fine also.
A recent update happened to add webrick to the Gemfile.lock indirectly, when
"yard" was updated since the new version of yard requires webrick. But it's
probably worth adding webrick to the Gemfile explicitly since we depend on it
for tests, not just for yard.