Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7 to tests #2132

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add Rails 7 to tests #2132

merged 1 commit into from
Jan 26, 2022

Conversation

jordan-brough
Copy link
Contributor

@jordan-brough jordan-brough commented Jan 25, 2022

And refactor ".circleci/config" a bit. With all the current variations & limitations it seems like it's probably better to just list
the supported configurations explicitly rather than trying to share config blocks.

NOTE: I haven't actually tried running administrate on a Rails 7 app! But I intend to upgrade to Rails 7 and I saw that tests pass for it here so I thought it'd be worth opening a PR at least.

And refactor ".circleci/config" a bit.

With all the current variations & limitations it's probably better to just list
the supported configurations explicitly rather than trying to share config
blocks.
Copy link
Member

@nickcharlton nickcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nickcharlton nickcharlton merged commit 1a6e0fc into thoughtbot:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants