New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on sassc / scss #2148

Closed

muriloime wants to merge 8 commits into thoughtbot:main from muriloime:main

muriloime commented Feb 22, 2022

Hello there,

I realized the sassc related gems are increasing our slug size in heroku by 10-20% so I decided to remove the (now deprecated) sassc dependencies. In the case this work is desirable by the maintainers, I am creating this PR

cheers
Murilo

Member

nickcharlton commented Feb 23, 2022

Thanks for jumping in and doing this. I've been keen to do this for the last few weeks, so I'm glad you've opened a PR about it.

@dcyoung-dev has a work in progress branch hanging around from when we initially looked at this, but it seems like this is a little further along, but I mention it in case you wanted to have a quick look.

Would you be able to do something about the Hound/style comments?

nickcharlton mentioned this pull request

Hard dependency on Sprockets prevents migration to Propshaft #2151

Closed

iainbeeston commented Mar 30, 2022

Any chance of hurrying this along? I have another reason for wanting this PR which is that I'm using Rails 7 with tailwind 3, and adding sassc into the mix causes tailwind to blow up with a [Error: Function rgb is missing argument $green](https://github.com/tailwindlabs/tailwindcss/discussions/6738) error (apparently due to sassc being old/out of date)

Author

muriloime commented Mar 30, 2022

@iainbeeston this PR broke in production. I added a WIP

muriloime changed the title ~~Remove dependency on sassc / scss~~ [WIP] Remove dependency on sassc / scss

brunoprietog commented Apr 12, 2022

I'm also unable to use Administrate because I'm using Tailwind. It would be great to see this PR merged. Thanks!

brent-yearone mentioned this pull request

Dart-sass compatibility #2198

Merged

muriloime added 5 commits

July 13, 2022 19:19


          remove sassc and scss

895662f


          scss => css

3188e62


          remove momentjs

686b332


          add url( )

418c317


          I've forgot to add these

769c762

muriloime force-pushed the main branch from 35decf2 to 769c762 Compare

July 13, 2022 17:35

muriloime added 3 commits

July 13, 2022 19:40


          remove all references to dreaded sassc

fce9bc6


          add relative path

ef77419


          correct url to be used by asset pipeline

2251c1a

hound bot reviewed

View reviewed changes

app/assets/config/administrate_manifest.js

		@@ -0,0 +1 @@
		//= link_tree ../stylesheets/administrate .css

hound bot Jul 14, 2022

Expected space or tab after '//' in comment spaced-comment

hound bot reviewed

View reviewed changes

app/assets/stylesheets/administrate/components/_buttons.css

+              button:disabled:hover,
+              input[type="button"]:disabled:hover,
+              input[type="reset"]:disabled:hover,
+              input[type="submit"]:disabled:hover,

hound bot Jul 14, 2022

Unexpected qualifying type selector selector-no-qualifying-type

app/assets/stylesheets/administrate/components/_buttons.css

+              }
+              button:disabled:hover,
+              input[type="button"]:disabled:hover,
+              input[type="reset"]:disabled:hover,

hound bot Jul 14, 2022

Unexpected qualifying type selector selector-no-qualifying-type

app/assets/stylesheets/administrate/components/_buttons.css

+                opacity: 0.5;
+              }
+              button:disabled:hover,
+              input[type="button"]:disabled:hover,

hound bot Jul 14, 2022

Unexpected qualifying type selector selector-no-qualifying-type

app/assets/stylesheets/administrate/components/_buttons.css

+                cursor: not-allowed;
+                opacity: 0.5;
+              }
+              button:disabled:hover,

hound bot Jul 14, 2022

Expected empty line before rule rule-empty-line-before

app/assets/stylesheets/administrate/components/_buttons.css

+              button:disabled,
+              input[type="button"]:disabled,
+              input[type="reset"]:disabled,
+              input[type="submit"]:disabled,

hound bot Jul 14, 2022

Unexpected qualifying type selector selector-no-qualifying-type

Author

muriloime commented Jul 14, 2022 •

edited

Loading

I had a lot of sassc errors in my CI/CD server when running tests so I came back to this issue.

I finally managed to remove sass. Unfortunately I had to change selectize-rails too, as it used .scss.

I acknowledge it is maybe not the best way to use the asset pipeline (multiple files), but it is working now in prod \o/, and it does not rely on scss anymore. I would be more than happy to discuss on how to improve the solution

In order to make it work is necessary to add this line to app's manifest file

//= link administrate_manifest.js

Cheers
Murilo

muriloime changed the title ~~[WIP] Remove dependency on sassc / scss~~ Remove dependency on sassc / scss

czepesch commented Jul 23, 2022

@muriloime hey!
I tried to deploy my app with Dokku using your fork, but have this error:
`-----> Preparing app for Rails asset pipeline
Running: rake assets:precompile

   Done in 1389ms.
   rake aborted!
   LoadError: cannot load such file -- sassc`

I added //= link administrate_manifest.js to manifest,js

I also can't do bundle exec rake assets:precompile locally:
rake aborted! LoadError: cannot load such file -- sassc
Any ideas?
Thanks!

Author

muriloime commented Jul 25, 2022

@muriloime hey! I tried to deploy my app with Dokku using your fork, but have this error: `-----> Preparing app for Rails asset pipeline Running: rake assets:precompile
   Done in 1389ms.
   rake aborted!
   LoadError: cannot load such file -- sassc`
I added //= link administrate_manifest.js to manifest,js

I also can't do bundle exec rake assets:precompile locally: rake aborted! LoadError: cannot load such file -- sassc Any ideas? Thanks!

Hey actually I had to modify selectize gem too ( and pointed the gem to my github fork). Very simple change, just changed the extension of the relevant files to me muriloime/selectize-rails@130c599.

czepesch commented Jul 25, 2022

@muriloime I don't have this gem in my project and don't think I should use at all. If so, there is no way to make administrate work? or it is possible to make similar changes somewhere else?

Author

muriloime commented Oct 11, 2022 via email

This gem is required by administrate

On Mon, 25 Jul 2022, 16:37 czepesch, ***@***.***> wrote: @muriloime <https://github.com/muriloime> I don't have this gem in my project and don't think I should use at all. If so, there is no way to make administrate work? or it is possible to make similar changes somewhere else? — Reply to this email directly, view it on GitHub <#2148 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXO4RTGMEBCFSEH4WXUKO3VV2RAXANCNFSM5PBE6ARQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

sodabrew commented Jan 11, 2023

Kudos for this work, would be glad to see it land and reduce deploy sizes substantially

MuhammetDilmac commented Jan 11, 2023

I think this pr has a urgent priority because of tailwind conflict. Have a expected release date?

Author

muriloime commented Jan 12, 2023

@MuhammetDilmac @sodabrew I don't know if this PR will ever see the light of day, as it required changes on other gems as well. I use this in production but I had to point to github versions of other gems. If some admin has an idea and are willing to release this change I am more than prone to discuss.

sodabrew commented Jan 17, 2023

@muriloime was the only other change in selectize-rails? The version of Selectize used by selectize-rails is wildly out of date and looking at https://github.com/manuelvanrijn/selectize-rails, seems unlikely to be updated anytime. I would suggest removing it by importing selectize.js into this PR directly from https://github.com/selectize/selectize.js#installation

Comparing notes across projects, there is a Selectize plugin for ActiveAdmin: https://github.com/blocknotes/activeadmin_selectize (rather than using selectize-rails -- yet also uses sassc at runtime)

nickcharlton mentioned this pull request

Asset Management #2311

Closed

3 tasks

Collaborator

pablobm commented Apr 18, 2023

Closing in favour of #2311

pablobm closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet