Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying out GitHub's code scanning tool #2154

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Trying out GitHub's code scanning tool #2154

merged 2 commits into from
Aug 11, 2022

Conversation

pablobm
Copy link
Collaborator

@pablobm pablobm commented Mar 3, 2022

@pablobm pablobm requested a review from nickcharlton March 3, 2022 18:00
@nickcharlton
Copy link
Member

nickcharlton commented Aug 8, 2022

This is neat! I tidied up the default workflow so that it's a lot smaller.

It's highlighted one issue we should fix in: spec/example_app/app/models/doc_page.rb:7

https://github.com/thoughtbot/administrate/security/code-scanning/1

@pablobm
Copy link
Collaborator Author

pablobm commented Aug 11, 2022

@nickcharlton - Fixed the security warning. I had to go out of my way a bit for the tool to accept it, as well as to be able to write a spec for it.

@nickcharlton
Copy link
Member

Oh nice, thanks!

@pablobm pablobm merged commit efe7aa6 into main Aug 11, 2022
@pablobm pablobm deleted the github-codeql branch August 11, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants