Enable ordering the BelongsTo fields by using order option. #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
14 times, most recently
from
8aa9b1a to
dedec29
Compare
The change let the gem users to be able to order the fields by the column they'll specify, instead of ordering by `id`. I've also updated the query to solve the possible issues with `PG::AmbiguousColumn` errors - for now it's not handled in any way, so if the user is using the tables that use the same columns names, then the error will apear and the only way to fix that is to monkey patch the gem. To solve that, I've added the column name as the prefix for both possible forms of the query.
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
from
dedec29 to
dd86160
Compare
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
from
0dbd2fa to
9a808a7
Compare
pablobm
reviewed
Jul 7, 2022
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
3 times, most recently
from
03c5b62 to
d38cd56
Compare
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
from
d38cd56 to
7265439
Compare
|
Hi @pablobm, AFAIU the failing CI tests are not related to my changes. I think I've done everything that you asked me to update/change/fix. 👍 |
pablobm
reviewed
Jul 8, 2022
patrickgramatowski
force-pushed
the
enable-sort-by-association-attribute
branch
from
7265439 to
1491ba3
Compare
This was referenced Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable ordering the BelongsTo fields by using order option. The change let the gem users to be able to order the fields by the column they'll specify, instead of ordering by
id.I've also updated the query to solve the possible issues with
PG::AmbiguousColumnerrors - for now it's not handled in any way, so if the user is using the tables that use the same columns names, then the error will apear and the only way to fix that is to monkey patch the gem. To solve that, I've added the column name as the prefix for both possible forms of the query.Based on #1215
And kinda related to #1805 the result is exactly as presented on videos attached to this task's description.