Guess correct class name for namespaced associations #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
pablobm
force-pushed
the
namespaced-associations
branch
2 times, most recently
from
4726a09 to
b991698
Compare
nickcharlton
approved these changes
Aug 8, 2022
Fixes thoughtbot#1978 This includes the namespace of the associated class. If the associated class is `System::Build`, the previous code would tell us that the name was `Build`. This code gets the right name.
nickcharlton
force-pushed
the
namespaced-associations
branch
from
b991698 to
01547f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1978 #2209
At
lib/administrate/field/associative.rb, we are currently using the wrong incantation to figure out the name of the associated class. What we have works most of the time, but will drop the namespace if there's one.For example: if
Blog::Post.has_many :tagsof typeBlog::Tags, it will incorrectly guess that the class name of:tagsis"Tag"instead of"Blog::Tag".This breaks the
Blog::PostDashboard, which thinks it has to link toTagDashboardinstead ofBlog::TagDashboard.The fix is just the one liner in that file. The rest is putting together an instance of this in the example app, and a spec to test it.