Use pundit policy_namespace in controllers

[bhtabor]

Add pundit policy_namespace to controllers
Deprecate resolve_admin from pundit policies

[bhtabor]

Fixes #1332

To use specific Policy Namespacing for authorization, like admin namespaced policies for example, just set the policy_namespace array like below.

module Admin
  class PostsController < ApplicationController
    include Administrate::Punditize

    def policy_namespace
      [:admin]
    end
  end
end

[pablobm]

Nice, thank you! I don't have much time now, but I'll review it a bit more thoroughly when I can.

One thing is that ideally I'd like to have some sort of back-compatibility hook where we show a warning to people using the old interface. Do you know how we could achieve this? If you don't, it's ok, I'll get to it. At least this PR gets us moving.

[bhtabor]

One thing is that ideally I'd like to have some sort of back-compatibility hook where we show a warning to people using the old interface. Do you know how we could achieve this? If you don't, it's ok, I'll get to it. At least this PR gets us moving.

Just added pundit policy scope resolve_admin deprecation. Thank you!

[pablobm]

One thing I can't find a good place to put: I think we should remove OrderPolicy#resolve_admin, for two reasons:

1. It pollutes the specs with warnings.
2. Our example app should avoid deprecated APIs.

The problem is that then this would break the specs you wrote to check for deprecations. I wonder if we can do this differently, perhaps adding #resolve_admin in a before block with metaprogramming, then remove it in the after block. Thoughts? I'm happy with having a much simpler spec for this, instead of looking

Anyway, this is looking pretty good! I want to give it another review though, so make sure I'm not missing anything as this could have large repercussions for many people.

Also I wonder if @nickcharlton or @littleforest would have some time to have a look too 👀

[bhtabor]

One thing I can't find a good place to put: I think we should remove OrderPolicy#resolve_admin, for two reasons:

1. It pollutes the specs with warnings.
2. Our example app should avoid deprecated APIs.

Totally agree. I've addressed those issues. Thank you!

[pablobm]

We are getting there! Once we resolve the open threads, I think this can be merged if my colleagues don't have any other comments.

[bhtabor]

We are getting there! Once we resolve the open threads, I think this can be merged if my colleagues don't have any other comments.

I've addressed the open issues and rebased to main. Thank you @pablobm!

[pablobm]

Let's go go go! 🚀

[pablobm]

Thank you @bhtabor 🙂