-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hasMany collection columns #2415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙂 Would you be able to add a test? I'm thinking a simple one would be to change the order dashboards to display the line items like this:
line_items: Field::HasMany.with_options(collection_attributes: [:product, :quantity, :unit_price, :total_price]),
Then you can check that the "Order" column doesn't appear. What do you think?
added |
Oof, build issue 😫 I think the issue is related to #2410. Would you be able to rebase on top of the latest |
merged main |
OK, let's go! 🚀 Thank you for the contribution 🙂 |
idea come from nickcharlton/administrate-field-nested_has_many#54 but I use positive list not only skip the column but also can add/remove/order the columns.