allow grouping fields (new, edit and show) #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for your contribution @patriciomacadden. Could you rebase (I've merged in a bunch of things in today) and perhaps add a screenshot to show what it looks like? |
patriciomacadden
force-pushed
the
group-fields
branch
from
76919ea to
5697ea7
Compare
|
Hey @nickcharlton absolutely. Just rebased. A couple screenshots:
I tried to be consistent, but happy to do any changes. |
|
Hi! Any chance to merge it? |
|
Brilliant, thanks! |
This provides an official way to go about grouping form fields when there's several which are related (for example an address). This is backwards compatible, works with i18n and also supports the `has_one` field.
nickcharlton
force-pushed
the
group-fields
branch
from
5697ea7 to
b861ed5
Compare
CharlotteBory
added a commit
to CharlotteBory/administrate
that referenced
this pull request
Jan 17, 2024
This reverts commit 6e03eb5.
CharlotteBory
added a commit
to CharlotteBory/administrate
that referenced
this pull request
Jan 17, 2024
…ping Revert "Allow grouping fields (new, edit and show) (thoughtbot#2422)"
nickcharlton
pushed a commit
to trevorrjohn/administrate-field-nested_has_many
that referenced
this pull request
Jan 25, 2024
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes nickcharlton#65
trevorrjohn
added a commit
to trevorrjohn/administrate-field-nested_has_many
that referenced
this pull request
Jan 26, 2024
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes nickcharlton#65
trevorrjohn
added a commit
to trevorrjohn/administrate-field-nested_has_many
that referenced
this pull request
Feb 5, 2024
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes nickcharlton#65
trevorrjohn
added a commit
to trevorrjohn/administrate-field-nested_has_many
that referenced
this pull request
Feb 8, 2024
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes nickcharlton#65
nickcharlton
pushed a commit
to nickcharlton/administrate-field-nested_has_many
that referenced
this pull request
Feb 14, 2024
In Administrate v0.20.0, support was added for grouping fields but this was not compatible with this field type. thoughtbot/administrate#2422 Fixes #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been using administrate for a couple of years and I really like the approach and enjoy using it. Thanks :)
A couple of times I needed to group fields when having models with a large number of fields and the lack of an official way made me do nasty things lol.
This PR adds the ability of grouping form attributes and show page attributes:
Let me know what you think!