Use reflection table name when ordering on association columns

[jordanstephens]

Ordering on association columns is broken if the associated model uses a non-standard table name. attribute.tableize is not sufficient.

For example, given these models

class Foo < ApplicationRecord
  has_one :bar
end

class Bar < ApplicationRecord
  self.table_name = "namespace_bars"
  belongs_to :foo
end

Administrate::Order assumes that ordering Foos by bar.name should add ORDER BY bars.name when in this case, it should be ORDER BY namespace_bars.name. The reflection contains the table_name, so this is easy to resolve by passing the reflection around to a few more.

[nickcharlton]

Nice, thanks!

It's not clear to me whether the test is reflecting the example you mentioned. Am I missing something, or is that not the case?

I think I'd expect to see something explicit for your example, so that we don't have regressions in future.