Enable running workflows from forks #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was tested on #2495, and then I cherry-picked that commit over. It's not possible to test it myself 🙃. |
The simple `push` event doesn't support pull requests from forks where the author doesn't already have write access to the repository. This adds the default set of events on the `pull_request` event which lets forks run the test suite. In addition, this expands that pattern to our other workflows (`bundle-audit` and `codeql-analysis`), whilst restricting the `push` workflow to only occur on `main` (which should mean re-triggering workflows on merge). This is to stop duplicating the builds when triggered by an actor with write access. https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request https://securitylab.github.com/research/github-actions-preventing-pwn-requests
nickcharlton
force-pushed
the
nc-enable-running-from-forks
branch
from
829cb3f to
daeb414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple
pushevent doesn't support pull requests from forks wherethe author doesn't already have write access to the repository.
This adds the default set of events on the
pull_requestevent whichlets forks run the test suite.
In addition, this expands that pattern to our other workflows
(
bundle-auditandcodeql-analysis), whilst restricting thepushworkflow to only occur on
main(which should mean re-triggeringworkflows on merge). This is to stop duplicating the builds when
triggered by an actor with write access.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request https://securitylab.github.com/research/github-actions-preventing-pwn-requests