Lint Ruby with standardrb #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
force-pushed
the
nc-lint-with-standard
branch
from
15894df to
fe92002
Compare
Some time ago, we at thoughtbot stopped using our custom Rubocop rules and replaced it with standard. This adds Standard, sets up support for it in GitHub Actions and runs it against the code base. We ignore `Lint/ConstantDefinitionInBlock` in a few specs, as this is related to the Pundit integration. It'd be good to come back to this in future and adjust the specs to avoid defining/overriding classes in specs, but honestly it was too difficult to make it work in a reasonable time. Finally, we need to use `main` of the standard Action as, currently, that's the only one which is working (`0.0.5` fails silently). https://github.com/standardrb/standard thoughtbot/guides#606
nickcharlton
force-pushed
the
nc-lint-with-standard
branch
from
7f4b03c to
401836d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, we at thoughtbot stopped using our custom Rubocop rules and replaced it with standard. This adds Standard, sets up support for it in GitHub Actions and runs it against the code base.
We ignore
Lint/ConstantDefinitionInBlockin a few specs, as this is related to the Pundit integration. It'd be good to come back to this in future and adjust the specs to avoid defining/overriding classes in specs, but honestly it was too difficult to make it work in a reasonable time.Finally, we need to use
mainof the standard Action as, currently, that's the only one which is working (0.0.5fails silently).https://github.com/standardrb/standard
thoughtbot/guides#606