Generate fields/rich_text/form with documentation
#2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
rich-text-documentation
branch
2 times, most recently
from
2c0b08c to
c61961e
Compare
All form partials include guiding documentation atop the template files. Those comments are valuable additions, since view template overrides installed via generators will include them. This commit updates the new `fields/rich_text/form` partial to include documentation. On the test side, this commit also includes changes to view specs to generate Form Builders using *real* Action View form builders and view helpers. Removing code that mimicked that builder instantiation uncovered an error in a how the Rich Text form partial coverage expected the `<trix-editor>` element's corresponding `<input type="hidden">` element generated its `[id]`.
seanpdoyle
force-pushed
the
rich-text-documentation
branch
from
c61961e to
9f1efce
Compare
pablobm
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All form partials include guiding documentation atop the template files. Those comments are valuable additions, since view template overrides installed via generators will include them.
This commit updates the new
fields/rich_text/formpartial to include documentation.On the test side, this commit also includes changes to view specs to generate Form Builders using real Action View form builders and view helpers.
Removing code that mimicked that builder instantiation uncovered an error in a how the Rich Text form partial coverage expected the
<trix-editor>element's corresponding<input type="hidden">element generated its[id].