Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature-test coverage for Rich Text Field #2700

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

seanpdoyle
Copy link
Contributor

Follow-up to #2411

Add Capybara-driven feature test coverage for filling in and rendering the contents of a <trix-editor> element.

@seanpdoyle seanpdoyle force-pushed the action-text-test-coverage branch 7 times, most recently from d165828 to d8bf811 Compare November 1, 2024 17:00
Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment.

spec/features/products_form_spec.rb Outdated Show resolved Hide resolved
spec/features/products_form_spec.rb Show resolved Hide resolved
@@ -0,0 +1,23 @@
module Features
if Rails.version >= "6.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just 0.1 requirements of a version away from doing away with this part 😄 I wonder if we should drop support for 6.* now that they have been EOL'd (https://rubyonrails.org/2024/10/15/new-maintenance-policy-and-eol-annouments). Thoughts, @nickcharlton?

But since this is here and solved for now, I think it's not a blocker. We can decide about Rails requirement separately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perhaps a separate discussion, but I wonder if we can drop support post-1.0 (1.1?).

I don't want 1.0 to be so big that it means people avoid upgrading (which is a good argument to call it in the next few weeks?), then drop it on the next release. It's a bit similar to how Apple does it with macOS.

Follow-up to [#2411][]

Add Capybara-driven feature test coverage for filling in and rendering
the contents of a `<trix-editor>` element.

[#2411]: #2411
@seanpdoyle seanpdoyle force-pushed the action-text-test-coverage branch from 5599c90 to 881ef61 Compare November 1, 2024 17:21
@seanpdoyle seanpdoyle merged commit a3283bf into main Nov 1, 2024
11 checks passed
@seanpdoyle seanpdoyle deleted the action-text-test-coverage branch November 1, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants