Add link to show resource from collection table #727
Conversation
Allows a resource to be shown without javascript enabled (using "data-url"). Also facilitates faster tests using RackTest.
| @@ -22,6 +22,15 @@ | |||
| expect(page).to have_content(customer.email) | |||
| end | |||
|
|
|||
| it "links to the customer show page without javascript", js: false do | |||
There was a problem hiding this comment.
I wonder if this means that now we'll be able to disable JavaScript by default and enable JS instead?
There was a problem hiding this comment.
I think the default driver is currently RackTest for most of the feature specs. The js: false is redundant but I put it there to be explicit.
11 / 56 feature specs enable javascript with the :js flag:
bundle exec rspec spec/features
# 56 examples, 0 failures
bundle exec rspec spec/features --tag js
# 11 examples, 0 failures
We could convert these to use the hyperlink, but it's quite handy to have the coverage & confidence the data-url / JS option still works.
What do you think @nickcharlton?
There was a problem hiding this comment.
Oh sorry... re-reading your comment. Do you mean invert the test names? So links to the customer show page is the vanilla version, then links to the customer show page with javascript or similar?
|
I like it! |
Allows a resource to be shown without javascript enabled (which uses "data-url" attrs). Also facilitates faster tests using RackTest.
Adds a link to show the resource within each cell of the collection table, as an alternative to the
data-urlon thetr. The link is styled with the default text colour so there's no visual change.This allows a resource to be shown without javascript enabled (and also facilitates faster tests using RackTest).
On my machine running the same test comparing:
click_show_link_for(+ no JS)click_row_for(+ with JS)is a lot faster, as expected:
(in seconds, running each test independently, excluding file load times)