Merge the existing translations before testing. #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`with_translations` is used to test that a view does actually implement a given translation. Previously, we were resetting the known translations to only use the one under test. We now have many more translations so this approach will fail when visiting a page because of "missing translations". Example: https://git.io/vywpc This came up when merging #344.
nburkley
added a commit
to nburkley/administrate
that referenced
this pull request
Mar 24, 2017
The `with_translations` helper allows translations to be setup for a method under test. A recent change (thoughtbot#772) added a backend chain to ensure this helper won't break other spec by replacing all translations and causing "missing_translations" failures. This changes the order of the I18n backends so that specs will first use the translations provided to the `with_translations` block and then fallback to the default translations. Otherwise, there would be no way to override the default translations in test cases.
nickcharlton
pushed a commit
that referenced
this pull request
May 3, 2017
* Reorder I18n backends in `with_translations` helper The `with_translations` helper allows translations to be setup for a method under test. A recent change (#772) added a backend chain to ensure this helper won't break other spec by replacing all translations and causing "missing_translations" failures. This changes the order of the I18n backends so that specs will first use the translations provided to the `with_translations` block and then fallback to the default translations. Otherwise, there would be no way to override the default translations in test cases. * Adds format option to DateTime field Updates DateTime field to accept 'format' option which determines the display format of the field. The option can be * A key for the localized date format in the corresponding yaml config file * A strftime format string
jonatack
pushed a commit
to jonatack/administrate
that referenced
this pull request
May 6, 2017
* Reorder I18n backends in `with_translations` helper The `with_translations` helper allows translations to be setup for a method under test. A recent change (thoughtbot#772) added a backend chain to ensure this helper won't break other spec by replacing all translations and causing "missing_translations" failures. This changes the order of the I18n backends so that specs will first use the translations provided to the `with_translations` block and then fallback to the default translations. Otherwise, there would be no way to override the default translations in test cases. * Adds format option to DateTime field Updates DateTime field to accept 'format' option which determines the display format of the field. The option can be * A key for the localized date format in the corresponding yaml config file * A strftime format string
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
* Reorder I18n backends in `with_translations` helper The `with_translations` helper allows translations to be setup for a method under test. A recent change (thoughtbot#772) added a backend chain to ensure this helper won't break other spec by replacing all translations and causing "missing_translations" failures. This changes the order of the I18n backends so that specs will first use the translations provided to the `with_translations` block and then fallback to the default translations. Otherwise, there would be no way to override the default translations in test cases. * Adds format option to DateTime field Updates DateTime field to accept 'format' option which determines the display format of the field. The option can be * A key for the localized date format in the corresponding yaml config file * A strftime format string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_translationsis used to test that a view does actually implementa given translation. Previously, we were resetting the known
translations to only use the one under test. We now have many more
translations so this approach will fail when visiting a page because of
"missing translations".
Example: https://git.io/vywpc
This came up when merging #344.