Stop using Sass glob importing #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glob importing is a feature of sass-rails. It makes for cleanly and
easily importing lots of partials, but it completely hides Sass errors.
For example, when you miss a semicolon and your Sass doesn't compile,
using glob imports with sass-rails you simply see an application error:
"We're sorry, but something went wrong."
But when using standard Sass imports, this error is an actual syntax
error, which provides helpful messaging ("Invalid CSS after…"), and
traces back to the source where the error was introduced.
tysongach
force-pushed
the
tg-sass-imports
branch
from
a0fcdf7 to
fec2559
Compare
BenMorganIO
approved these changes
Apr 4, 2017
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
Glob importing is a feature of sass-rails. It makes for cleanly and
easily importing lots of partials, but it completely hides Sass errors.
For example, when you miss a semicolon and your Sass doesn't compile,
using glob imports with sass-rails you simply see an application error:
"We're sorry, but something went wrong."
But when using standard Sass imports, this error is an actual syntax
error, which provides helpful messaging ("Invalid CSS after…"), and
traces back to the source where the error was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glob importing is a feature of sass-rails. It makes for cleanly and
easily importing lots of partials, but it completely hides Sass errors.
For example, when you miss a semicolon and your Sass doesn't compile,
using glob imports with sass-rails you simply see an application error:
"We're sorry, but something went wrong."
But when using standard Sass imports, this error is an actual syntax
error, which provides helpful messaging ("Invalid CSS after…"), and
traces back to the source where the error was introduced.
Before
After