Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace around main content box #862

Merged
merged 1 commit into from
May 5, 2017

Conversation

tysongach
Copy link
Contributor

After this PR:

screen shot 2017-05-05 at 15 56 46

Before:

screen shot 2017-05-05 at 15 56 59

@tysongach tysongach added the views-and-styles how administrate looks and is interacted with label May 5, 2017
@BenMorganIO BenMorganIO merged commit 05af159 into tg-navigation May 5, 2017
@BenMorganIO BenMorganIO deleted the tg-app-container branch May 5, 2017 21:15
BenMorganIO pushed a commit that referenced this pull request May 5, 2017
* Tweak primary navigation

- Rename `sidebar` to `navigation`, which is based on its purpose rather
  than its visual placement.
- Use `nav` element.
- Remove unnecessary `ul`; the `nav` provides enough semantics to wrap
  the links in.
- Tweak visual design: show a light background on hover, add more
  whitespace between navigation links and main content.

* Add whitespace around main content box (#862)
jonatack pushed a commit to jonatack/administrate that referenced this pull request May 6, 2017
* Tweak primary navigation

- Rename `sidebar` to `navigation`, which is based on its purpose rather
  than its visual placement.
- Use `nav` element.
- Remove unnecessary `ul`; the `nav` provides enough semantics to wrap
  the links in.
- Tweak visual design: show a light background on hover, add more
  whitespace between navigation links and main content.

* Add whitespace around main content box (thoughtbot#862)
iarie pushed a commit to iarie/administrate that referenced this pull request Jun 17, 2017
* Tweak primary navigation

- Rename `sidebar` to `navigation`, which is based on its purpose rather
  than its visual placement.
- Use `nav` element.
- Remove unnecessary `ul`; the `nav` provides enough semantics to wrap
  the links in.
- Tweak visual design: show a light background on hover, add more
  whitespace between navigation links and main content.

* Add whitespace around main content box (thoughtbot#862)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
views-and-styles how administrate looks and is interacted with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants