Implement Bundler install_if #176

n-rodriguez · 2021-01-01T17:52:43Z

This an attempt to fix: #131

The trick here is to store the conditional as plain string. As explained here #132 (comment) :

We dont want the lambda evaluated on generate, we want it evaluated on bundle install. No idea how to do that and im too pneumonia sick to think :D

IMHO the easiest way is to write/store it as a string and render it directly in the generated file (verbatim).

So in Appraisal file :

install_if -> { ENV["DB_ADAPTER"] == "mysql2" } do
  gem 'mysql'
end

becomes

install_if '-> { ENV["DB_ADAPTER"] == "mysql2" }' do
  gem 'mysql'
end

After generation it becomes (in gemfiles/*.gemfile) :

install_if -> { ENV["DB_ADAPTER"] == "mysql2" } do
  gem 'mysql'
end

It should help to solve most use cases since you can put any valid Ruby code here :).

At first I tried https://github.com/banister/method_source but it immediately failed.

Because :

Cannot return source for dynamically defined methods.

So I ended up with this easy solution that does the job.

n-rodriguez · 2021-01-01T17:56:02Z

With real world example :

The diff with generated gemfiles : https://github.com/jbox-web/ajax-datatables-rails/compare/wip/appraisal
The CI https://github.com/jbox-web/ajax-datatables-rails/actions/runs/456470055

n-rodriguez · 2021-01-01T17:57:37Z

The nice thing : it even merges gems with duplicated conditions :

install_if -> { ENV["DB_ADAPTER"] == "oracle_enhanced" } do
  gem "activerecord-oracle_enhanced-adapter", "~> 5.2.0"
  gem "ruby-oci8"
end

Here the yaml structure that generate gemfiles : https://github.com/jbox-web/ajax-datatables-rails/compare/wip/appraisal#diff-a7e1dc0d2145599ae30f5d8cdfa163e79e7708040d2f7cf36b36fab4559974a8R30

n-rodriguez · 2021-01-01T18:02:47Z

lib/appraisal/bundler_dsl.rb

@@ -124,7 +131,7 @@ def dependencies_entry_for_dup
      @dependencies.for_dup
    end

-    [:gits, :paths, :platforms, :groups, :source_blocks].
+    [:gits, :paths, :platforms, :groups, :source_blocks, :install_if].


should I fix it?

n-rodriguez · 2021-01-01T18:02:51Z

lib/appraisal/bundler_dsl.rb

@@ -5,7 +5,7 @@ class BundlerDSL
    attr_reader :dependencies

    PARTS = %w(source ruby_version gits paths dependencies groups
-      platforms source_blocks gemspec)
+      platforms source_blocks install_if gemspec)


should I fix it?

Fix: #131

n-rodriguez · 2021-01-06T17:33:01Z

@nickcharlton wdyt?

n-rodriguez · 2021-01-16T10:09:37Z

Hi there! any news?

n-rodriguez · 2021-02-18T23:59:42Z

Ping @nickcharlton

n-rodriguez · 2021-02-26T11:26:24Z

Hi there! Any news?

n-rodriguez · 2021-03-20T15:25:03Z

It would be nice to have some news...

I hope I've not worked for nothing....

n-rodriguez · 2021-03-20T15:25:23Z

Ping @nickcharlton

n-rodriguez · 2021-04-06T11:42:30Z

Ping @nickcharlton

n-rodriguez · 2021-05-31T23:22:17Z

Ping @nickcharlton

nickcharlton

Thank you for keeping this alive, @n-rodriguez and sorry for the long wait.

Two points on some Hound issues, if you could take a look at those, I'll come back and get this merged!

nickcharlton · 2021-06-25T16:58:53Z

lib/appraisal/bundler_dsl.rb

@@ -5,7 +5,7 @@ class BundlerDSL
    attr_reader :dependencies

    PARTS = %w(source ruby_version gits paths dependencies groups
-      platforms source_blocks gemspec)
+      platforms source_blocks install_if gemspec)


Yes please!

nickcharlton · 2021-06-25T16:59:05Z

lib/appraisal/bundler_dsl.rb

@@ -124,7 +131,7 @@ def dependencies_entry_for_dup
      @dependencies.for_dup
    end

-    [:gits, :paths, :platforms, :groups, :source_blocks].
+    [:gits, :paths, :platforms, :groups, :source_blocks, :install_if].


Yes please!

n-rodriguez · 2021-08-06T22:59:35Z

@nickcharlton ping

nickcharlton · 2021-08-09T11:54:22Z

Thanks for the ping! I'm going to merge this now.

It'll go out in our next release, which will be once we fix #173.

Failure/Error: Combustion.initialize! :active_record, :action_controller SyntaxError: /home/nicolas/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/appraisal-40956d3ae826/lib/appraisal/gemfile.rb:33: syntax error, unexpected `end', expecting end-of-input Instead of using a raw String as explained here (thoughtbot#176) it uses the interpreted version: <Proc:0x00007f7aab911770 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:8 (lambda)> <Proc:0x00007f7aab9177d8 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:12 (lambda)> <Proc:0x00007f7aab917490 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:16 (lambda)> "-> { ENV[\"DB_ADAPTER\"] == \"sqlite3\" }" "-> { ENV[\"DB_ADAPTER\"] == \"mysql2\" }" "-> { ENV[\"DB_ADAPTER\"] == \"oracle_enhanced\" }"

adrianthedev · 2023-02-01T13:30:23Z

For some reason, the install_if method doesn't work for me.

install_if -> { ENV["CI"] } do
  gem "pluggy", path: "./gems/pluggy"
end

nickcharlton · 2023-02-01T14:41:08Z

Can you open a new issue? Ideally with something we can try and replicate with!

n-rodriguez · 2023-02-01T14:52:15Z

From your screenshot I see appraisal-2.4.1. This feature doesn't exist in this version, you need to use the main/master branch of appraisal.

By the way be sure to use quotes in your Appraisal file.

See: #176 (comment)

n-rodriguez · 2023-02-01T14:52:43Z

@nickcharlton maybe it's time to cut a new release? v2.4.1...master :)

adrianthedev · 2023-02-01T15:26:43Z

Thanks @n-rodriguez. I only checked to see if I'm on the latest version. The main/master instruction missed me.

Will try now.

nickcharlton · 2023-02-01T15:28:38Z

There will be a new issue soon. I'm tracking a few issues/catching up with lots of bundler changes so I think it's important to test these well.

Failure/Error: Combustion.initialize! :active_record, :action_controller SyntaxError: /home/nicolas/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/bundler/gems/appraisal-40956d3ae826/lib/appraisal/gemfile.rb:33: syntax error, unexpected `end', expecting end-of-input Instead of using a raw String as explained here (thoughtbot#176) it uses the interpreted version: <Proc:0x00007f7aab911770 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:8 (lambda)> <Proc:0x00007f7aab9177d8 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:12 (lambda)> <Proc:0x00007f7aab917490 /home/nicolas/PROJECTS/CONCERTO/gems/ajax-datatables-rails/gemfiles/rails_6.1.4.gemfile:16 (lambda)> "-> { ENV[\"DB_ADAPTER\"] == \"sqlite3\" }" "-> { ENV[\"DB_ADAPTER\"] == \"mysql2\" }" "-> { ENV[\"DB_ADAPTER\"] == \"oracle_enhanced\" }"

```sh An error occurred while loading ./spec/draper/draper_spec.rb. Failure/Error: Bundler.require(*Rails.groups) SyntaxError: /Users/nicolas/.asdf/installs/ruby/3.3.3/lib/ruby/gems/3.3.0/gems/appraisal-2.5.0/lib/appraisal/gemfile.rb:52: syntax error, unexpected `end' ``` Instead of using a raw String as explained here (thoughtbot#176) it uses the interpreted version: ```sh --- |- source "https://rubygems.org" gem "appraisal" gem "capybara" gem "cuprite" gem "database_cleaner" gem "factory_bot" gem "faker" gem "guard-rspec" gem "puma" gem "rake" gem "rspec-rails" gem "rspec-retry" gem "rubocop" gem "rubocop-capybara" gem "rubocop-factory_bot" gem "rubocop-rake" gem "rubocop-rspec" gem "simplecov" gem "sqlite3", "~> 1.5.0" gem "rails", "6.1.7" install_if #<Proc:0x000000011f590cc0 /Users/nicolas/PROJECTS/CONCERTO/gems/draper/gemfiles/rails_6.1.7.gemfile:25 (lambda)> do gem "net-imap" gem "net-pop" gem "net-smtp" end install_if #<Proc:0x000000011f5909f0 /Users/nicolas/PROJECTS/CONCERTO/gems/draper/gemfiles/rails_6.1.7.gemfile:31 (lambda)> do gem "base64" gem "bigdecimal" gem "mutex_m" gem "drb" gem "logger" end gemspec path: "../" ```

```sh An error occurred while loading ./spec/draper/draper_spec.rb. Failure/Error: Bundler.require(*Rails.groups) SyntaxError: /Users/nicolas/.asdf/installs/ruby/3.3.3/lib/ruby/gems/3.3.0/gems/appraisal-2.5.0/lib/appraisal/gemfile.rb:52: syntax error, unexpected `end' ``` Instead of using a raw String as explained here (#176) it uses the interpreted version: ```sh --- |- source "https://rubygems.org" gem "appraisal" gem "capybara" gem "cuprite" gem "database_cleaner" gem "factory_bot" gem "faker" gem "guard-rspec" gem "puma" gem "rake" gem "rspec-rails" gem "rspec-retry" gem "rubocop" gem "rubocop-capybara" gem "rubocop-factory_bot" gem "rubocop-rake" gem "rubocop-rspec" gem "simplecov" gem "sqlite3", "~> 1.5.0" gem "rails", "6.1.7" install_if #<Proc:0x000000011f590cc0 /Users/nicolas/PROJECTS/CONCERTO/gems/draper/gemfiles/rails_6.1.7.gemfile:25 (lambda)> do gem "net-imap" gem "net-pop" gem "net-smtp" end install_if #<Proc:0x000000011f5909f0 /Users/nicolas/PROJECTS/CONCERTO/gems/draper/gemfiles/rails_6.1.7.gemfile:31 (lambda)> do gem "base64" gem "bigdecimal" gem "mutex_m" gem "drb" gem "logger" end gemspec path: "../" ```

n-rodriguez commented Jan 1, 2021

View reviewed changes

Implement Bundler install_if

f2c7f59

Fix: #131

n-rodriguez mentioned this pull request Jan 6, 2021

install_if is missing #131

Closed

n-rodriguez mentioned this pull request May 1, 2021

Support for multiple rubies? #182

Closed

nickcharlton reviewed Jun 25, 2021

View reviewed changes

Fix coding style

8aa199c

nickcharlton merged commit 2f5be65 into thoughtbot:master Aug 9, 2021

n-rodriguez mentioned this pull request Feb 1, 2023

Cut a new release #203

Closed

nunommc mentioned this pull request Jun 13, 2023

bundle check returning exit code 1 but gems don't get installed #211

Closed

apauly mentioned this pull request Nov 9, 2023

Implement custom preloads - backport to 4-x-stable salsify/goldiloader#132

Closed

n-rodriguez mentioned this pull request Aug 3, 2024

Fix error when using Appraisal and install_if #226

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Bundler install_if #176

Implement Bundler install_if #176

n-rodriguez commented Jan 1, 2021 •

edited

Loading

n-rodriguez commented Jan 1, 2021

n-rodriguez commented Jan 1, 2021 •

edited

Loading

n-rodriguez Jan 1, 2021

n-rodriguez Jan 1, 2021

n-rodriguez commented Jan 6, 2021

n-rodriguez commented Jan 16, 2021

n-rodriguez commented Feb 18, 2021

n-rodriguez commented Feb 26, 2021

n-rodriguez commented Mar 20, 2021

n-rodriguez commented Mar 20, 2021

n-rodriguez commented Apr 6, 2021

n-rodriguez commented May 31, 2021

nickcharlton left a comment

nickcharlton Jun 25, 2021

nickcharlton Jun 25, 2021

n-rodriguez commented Aug 6, 2021

nickcharlton commented Aug 9, 2021

adrianthedev commented Feb 1, 2023

nickcharlton commented Feb 1, 2023

n-rodriguez commented Feb 1, 2023

n-rodriguez commented Feb 1, 2023 •

edited

Loading

adrianthedev commented Feb 1, 2023

nickcharlton commented Feb 1, 2023

Implement Bundler install_if #176

Implement Bundler install_if #176

Conversation

n-rodriguez commented Jan 1, 2021 • edited Loading

n-rodriguez commented Jan 1, 2021

n-rodriguez commented Jan 1, 2021 • edited Loading

n-rodriguez Jan 1, 2021

Choose a reason for hiding this comment

n-rodriguez Jan 1, 2021

Choose a reason for hiding this comment

n-rodriguez commented Jan 6, 2021

n-rodriguez commented Jan 16, 2021

n-rodriguez commented Feb 18, 2021

n-rodriguez commented Feb 26, 2021

n-rodriguez commented Mar 20, 2021

n-rodriguez commented Mar 20, 2021

n-rodriguez commented Apr 6, 2021

n-rodriguez commented May 31, 2021

nickcharlton left a comment

Choose a reason for hiding this comment

nickcharlton Jun 25, 2021

Choose a reason for hiding this comment

nickcharlton Jun 25, 2021

Choose a reason for hiding this comment

n-rodriguez commented Aug 6, 2021

nickcharlton commented Aug 9, 2021

adrianthedev commented Feb 1, 2023

nickcharlton commented Feb 1, 2023

n-rodriguez commented Feb 1, 2023

n-rodriguez commented Feb 1, 2023 • edited Loading

adrianthedev commented Feb 1, 2023

nickcharlton commented Feb 1, 2023

n-rodriguez commented Jan 1, 2021 •

edited

Loading

n-rodriguez commented Jan 1, 2021 •

edited

Loading

n-rodriguez commented Feb 1, 2023 •

edited

Loading