Add gemfile variables #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-sharp
force-pushed
the
add_gemfile_variables
branch
from
e5d2cec to
86db4b8
Compare
|
This PR contains the commit from #222 but is otherwise ready for review |
joe-sharp
force-pushed
the
add_gemfile_variables
branch
3 times, most recently
from
3281de5 to
66dc1de
Compare
joe-sharp
force-pushed
the
add_gemfile_variables
branch
from
66dc1de to
53ad665
Compare
|
Nice! Thanks for doing this. Could you add a line to the README mentioning it? |
|
@nickcharlton , done and I added a few more useful variables as well. All documented and covered by specs! 😁 |
|
@nickcharlton I believe this is ready to merge. Thanks! |
nickcharlton
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in #191 (comment), it seems desirable to be able to use variables in
customize_gemfilesso that custom instructions can be provided. I have added the most likely used options, but I am open to additional ideas.I also wanted to rewrite the specs to make them a bit easier to troubleshoot if they fail. I added a spec to cover the issue fixed in #222 and coverage for the new variables feature added here.