Use api.sendgrid.com instead of non-api version #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed? ============= Sendgrid's docs state, > A Host. The host for Web API v3 requests is always https://api.sendgrid.com/v3/ Bamboo has the base uri as https:/sendgrid.com/v3/. It seems that when commit e8e9816 updated to use v3, we somehow lost the `api` portion. For more see sendgrid's docs: https://sendgrid.com/docs/for-developers/sending-email/api-getting-started/
danbee
approved these changes
Aug 13, 2020
jutonz
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544
What changed?
Sendgrid's docs state,
Bamboo has the base uri as https:/sendgrid.com/v3/. It seems that when commit e8e9816 updated to use v3, we somehow lost the
apiportion.For more see sendgrid's docs: https://sendgrid.com/docs/for-developers/sending-email/api-getting-started/