Document 6.0.0 may break FactoryBot.lint
#1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azfletch
approved these changes
Jul 26, 2022
calebhearth
suggested changes
Sep 23, 2022
NEWS.md
Outdated
| @@ -21,7 +21,7 @@ | |||
| * Added: automatic definition of traits for Active Record enum attributes, enabled by default | |||
| (Note that this required changing where factory_bot constantizes the build | |||
| class, which may affect applications that were using abstract factories for | |||
| inheritance. See issue #1409.) | |||
| inheritance. See issue #1409.) (This may break `FactoryBot.lint` because there may be previously non-existing factory+trait combinations being defined and checked) | |||
There was a problem hiding this comment.
This should be wrapped to 80 chars to match the rest of this file.
There was a problem hiding this comment.
I have amended and push 710dd7a instead
choznerol
force-pushed
the
docs/6-0-0-breaks-FactoryBot-lint
branch
2 times, most recently
from
710dd7a
to
37956ee
Compare
In a sufficiently large codebase, the automatic definition of traits for Active Record enum may result in more combinations being checked by `FactoryBot.lint`. This breaking change may not be obvious because the first impression of the error messages may be "these factories were passing before the upgrade but now failing ?", while the truth is that they don't exist before the upgrade.
mike-burns
force-pushed
the
docs/6-0-0-breaks-FactoryBot-lint
branch
from
37956ee
to
e17be4a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a sufficiently large codebase, the automatic definition of traits for Active Record enum (#1380) may result in more combinations being checked by
FactoryBot.lint. This breaking change may not be obvious because the first impression of the error messages may be "these factories were passing before the upgrade but now failing ?", while the truth is that they don't exist before the upgrade. It took me a while to realize this so I hope adding this note could help people be aware of this situation when upgrading.