Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guideline on symbol to_proc #183

Merged
merged 1 commit into from
Jun 23, 2014
Merged

Add guideline on symbol to_proc #183

merged 1 commit into from
Jun 23, 2014
+8 −2

Conversation

jferris
Copy link
Contributor

@jferris jferris commented Jun 4, 2014

  • Using &:method_name is brief but clear
  • Using it consistently aids readability
  • Preferring simple method calls encourages simple methods

@jferris jferris mentioned this pull request Jun 4, 2014
Closed
@gabebw
Copy link
Contributor

gabebw commented Jun 4, 2014

Huge fan of Symbol#to_proc. I vote yes.

@gylaz
Copy link
Contributor

gylaz commented Jun 4, 2014

👍

@calleluks
Copy link
Contributor

I agree.

@sikachu
Copy link
Contributor

sikachu commented Jun 5, 2014

👍

1 similar comment
@mcmire
Copy link

mcmire commented Jun 5, 2014

👍

@mike-burns
Copy link
Contributor

Should we go further and state Prefer methods that can be called using Symbol#to_proc? Or is that out of scope?

@gabebw
Copy link
Contributor

gabebw commented Jun 9, 2014

I'm in favor of that guideline. Maybe it should be a in a new PR, though.

@jferris
Copy link
Contributor Author

jferris commented Jun 23, 2014

@mike-burns I'd be interested in a proposal to include that, but I'd prefer not to derails this (currently simple) change.

@jferris jferris merged commit 22133dd into master Jun 23, 2014
@jferris jferris deleted the jf-symbol-to-proc branch June 23, 2014 15:06
@jferris
Add guideline on symbol to_proc

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 5009E0832F4D3DD3
Verified
Learn about vigilant mode
22133dd 
* Using &:method_name is brief but clear
* Using it consistently aids readability
* Preferring simple method calls encourages simple methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jferris @gabebw @gylaz @calleluks @sikachu @mcmire @mike-burns