Rename Testing guide to Testing with RSpec #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our testing guide was RSpec specific. This change renames it from `testing` to `testing-rspec` and rolling the best practices into the guide. This is the first step towards #611 where we can have a general testing guide as well as a guide for each framework.
mike-burns
reviewed
Jun 19, 2020
|
@mike-burns I just saw your comments on keeping some of the guidelines. In this PR, I have not removed any; only renamed and formatted the document. |
|
Oh! Sorry, I misread. My fault. This looks great to me! |
mike-burns
approved these changes
Jun 25, 2020
ericwbailey
added a commit
that referenced
this pull request
Oct 24, 2020
* main: Expand the stack to include client-side frameworks Add HTML validation best practice (#588) Wrap in code to be consistent with line above’s factories.rb (#625) Remove the deprecated jscs configuration (#622) Restore Rubocop & Hound configuration (#623) Prefer MVVM on Android Update our Android best practices Added def tags to Data Glossary (#620) Fix typo in function components URL (#624) Fix broken link Ensure that guides have consistent formatting (#618) Combine style, best practice, and protocol guides (#615) Remove private/protected style guideline Rename Testing guide to Testing with RSpec (#614) Add back .rubocop.yml # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our testing guide was RSpec specific. This change renames it from
testingtotesting-rspecand rolling the best practices into the guide. This is the first step towards #611 where we can have a general testing guide as well as a guide for each framework.