Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust routes drawing to be compatible with Rails main #336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luizkowalski
Copy link

Some days ago, Rails changed how the routing mapper accept parameters so that it expects keywords instead of hashes.

This PR adjusts High Voltage so that it stops printing deprecation warnings.

All tests should continue to pass

@emilford
Copy link

emilford commented Dec 2, 2024

Thanks for opening this @luizkowalski. I should have some time this upcoming Friday to look at this.

Since this routing change was reverted once already, we might wait until the change gets included in a release.

We should also get this testing against Rails 8, now that that's been released.

@luizkowalski
Copy link
Author

Since this routing change was reverted once already, we might wait until the change gets included in a release.

makes sense, I will keep an eye and will come back to it when a new release includes this change

We should also get this testing against Rails 8, now that that's been released.

Opened a separated PR for it and will rebase after merged, I think it's best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants