Ignore shellcheck warning SC3043 globally in script #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning states that "In POSIX sh, 'local' is undefined". `local` is used extensively in the mac script, but it should be understood by most OSes based on the information in: https://stackoverflow.com/questions/18597697/posix-compliant-way-to-scope-variables-to-a-function-in-a-shell-script#answer-18600920 Add a line at the beginning of the script to ignore this warning in the entire file to avoid false positives when linting locally.
|
@rreinhardt9 This PR was made against master, which no longer exists. I'd like to give you credit for the change, but you don't have your email listed publicly on GitHub. Feel free to email me at chad at thoughtbot.com and I can give you proper attribution for the commit. Thanks again. |
|
New PR is here #606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Thoughtbot!! Thanks for sharing this script with us all, it's served as an inspiration for me when working to develop my own laptop setup scripts ❤️
One thing I ran into when setting up this project locally is that shellcheck was warning about the use of
localthroughout the script. In #481 it looks like this was discussed and it was decided this was safe to ignore.I found out that you can ignore a shellcheck warning for the entire file by adding it to the top. Doing so in this case might be helpful in order to:
localwarning directly in the fileThought I'd share what I learned back in this PR in case it would be helpful. 🚀 No worries if it's not and we just want to close this and keep it as is!
References