S3 Regions in the cucubmer specs

thoughtbot · Aug 20, 2015 · b8221c6 · betesh · Aug 21, 2015 · betesh
1 parent 0e8c21b
commit b8221c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/features/basic_integration.feature b/features/basic_integration.feature
@@ -77,5 +77,5 @@ Feature: Rails integration
     And I attach the file "spec/support/fixtures/5k.png" to "Attachment" on S3
     And I press "Submit"
     Then I should see "Name: something"
-    And I should see an image with a path of "http://s3.amazonaws.com/paperclip/attachments/original/5k.png"
 "https://paperclip.s3.amazonaws.com#{definition[:path]}" 
 "https://paperclip.s3.amazonaws.com#{definition[:path]}" 
-    And the file at "http://s3.amazonaws.com/paperclip/attachments/original/5k.png" should be uploaded to S3
+    And I should see an image with a path of "http://s3-us-west-2.amazonaws.com/paperclip/attachments/original/5k.png"
+    And the file at "http://s3-us-west-2.amazonaws.com/paperclip/attachments/original/5k.png" should be uploaded to S3
diff --git a/lib/paperclip/storage/s3.rb b/lib/paperclip/storage/s3.rb
@@ -209,11 +209,12 @@ def s3_host_name
         host_name = @options[:s3_host_name]
         host_name = host_name.call(self) if host_name.is_a?(Proc)
 
-        host_name || s3_credentials[:s3_host_name] || "s3.amazonaws.com"
+        region = ["s3", s3_region].compact.join("-")
+        host_name || s3_credentials[:s3_host_name] || "#{region}.amazonaws.com"
       end
 
       def s3_region
-        region = @options[:s3_region]
+        region = @options[:s3_region] || s3_credentials[:s3_region]
         region = region.call(self) if region.is_a?(Proc)
 
         region || s3_credentials[:s3_region]