Aws sdk v2 #1730
Aws sdk v2 #1730
Conversation
danielwanja
commented
Dec 17, 2014
danielwanja
commented
- Added s3 storage implementation using the aws-sdk v2.
| @@ -114,6 +114,7 @@ module S3 | |||
| def self.extended base | |||
| begin | |||
| require 'aws-sdk' | |||
| require 'aws-sdk-v1' | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
* Fixed hound notification - removing unused exception variable.
| # {'Expires' => 1.year.from_now.httpdate}. If you use a Proc, headers are determined at | ||
| # runtime. Paperclip will call that Proc with attachment as the only argument. | ||
| # Can be defined both globally and within a style-specific hash. | ||
| # * +bucket+: This is the name of the S3 bucket that will store your files. Remember |
* Using Ruby 1.9 hash syntax * Using double-quoted strings * Space after missing comma * Wrapped lines over 80 characters, unless code was less readable
| s3_interface.bucket(bucket_name).create | ||
| end | ||
|
|
||
| def flush_writes #:nodoc: |
There was a problem hiding this comment.
Assignment Branch Condition size for flush_writes is too high. [31.89/15]
… to investigate difference in environments.
|
Do you guys really want me to fix all the houdci notifications. Even the line too long ones? Make code less readable in my view? What else would you like to see fixed for this to be accepted? |
|
some of those houndci warnings are super aggressive. would be nice to see this changeset get in! |
|
@danielwanja thank you for your work! |
|
@tute, my pleasure. Let me know what you thing of this changeset and what would be needed to have this merged. |
|
I would like to help with this. I already mocked up a solution for the AWS S3 gem at marcel/aws-s3#108 |
|
@nathantechie9 There is no change that needs to happen with the aws-s3 gem. Paperclip has been using the aws-sdk gem for some time now, which is a different gem, but aside from that, the library should not need to change to accommodate us. |
|
@danielwanja I would really appreciate it if you could look at the places Hound says are too complicated and refactor them a bit. Thanks! :) |
|
What's the issue with the regions? I'd like to help. |
|
Is the functionality in this PR comparable to that of #1903? |
|
Same idea, to use the new aws-sdk v2, different approach. PR #1903 On Wed, Jun 17, 2015 at 10:45 PM, Tute Costa notifications@github.com
|
|
AWS 2 support has been merged: #1903 (comment). Thanks for your work! |
