This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
make style optional in copy_to_local_file #2028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -446,10 +446,10 @@ def flush_deletes #:nodoc: | |||
| @queued_for_delete = [] | |||
| end | |||
|
|
|||
| def copy_to_local_file(style, local_dest_path) | |||
| def copy_to_local_file(local_dest_path, style_name = default_style) | |||
There was a problem hiding this comment.
We don't need to switch the order of parameters, can we leave them as they were? Thank you.
|
I'd rather have this method require the style and keep it explicit. If you think we can improve the documentation, or something else, please let me know. Thank you for sharing your work! |
jywarren
added a commit
to publiclab/spectral-workbench
that referenced
this pull request
Jan 25, 2022
jywarren
added a commit
to publiclab/spectral-workbench
that referenced
this pull request
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to use
copy_to_local_fileand was frustrated by the fact thatstylewas a required parameter. I had to dig intoAttachment::default_optionsto realize that:originalwas what I needed to pass.I changed
copy_to_local_fileso that the style falls back todefault_stylewhen not provided. This matches the behavior of existing methods likeexpiring_urlands3_object(inmodule S3).