This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Update s3.rb #2444
Closed
Update s3.rb #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-SDK has change their config
|
Isn't this a duplicate of #2438? |
|
Assuming that it has been fixed in #2438, it should be merge? |
|
Agreed. One should be merged, the other should be closed. I'm not sure what's going on with that: #2477 |
|
We have switched to aws-sdk-s3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS-SDK has change their config
They have stop using proxy_uri
https://github.com/aws/aws-sdk-ruby/blob/8ff3f1cedbac5820336c4df3f5d819ce8de6e1f6/aws-sdk-core/lib/seahorse/client/net_http/connection_pool.rb#L19
The seahorse client uses http_proxy.
One could overwrite paperclip setting by manually setting this with the AWS SDK gem, by doing:
AWS.config.update({
http_proxy: 'http://blah.blah.blah:8080'
})
Paperclip should stop doing config[:proxy_uri]