This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Current validation check in AttachmentContentTypeValidator is wrong #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| )) | ||
| end | ||
| end | ||
| unless value.blank? || allowed_types.any? { |type| type === value } |
There was a problem hiding this comment.
Can you convert the conditional to an if, so it will not look awkward when chaining? My head is almost exploding when trying to parse the unless ... || ... condition.
|
I have one comment in the code. After you're done, can you squash commit together and force push to your branch? Thank you. |
…wrong, it will add an error if any of the allowed_types fails comparison with value, so it will pass only if value is either empty or equals to each and every one of allowed_types. Add test to check that validation passes if even one of content types match.
|
Okay, I've squashed commits together and made condition more clear. |
|
That looks better, thanks a bunch! :D |
sikachu
added a commit
that referenced
this pull request
Mar 27, 2012
Fix AttachmentContentTypeValidator to work with multiple values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current validation check in AttachmentContentTypeValidator is simply wrong, it will add an error if any of the allowed_types fails comparison with value, so it will pass only if value is either empty or equals to each and every one of allowed_types.
Test suite on this validator uses only a single element as :allowed_types everywhere, so this error wasn't detected.
I've added a test to check this specific behavior.