Teach have_db_index about expression indexes #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 31, 2019
mcmire
force-pushed
the
extend-have-db-index
branch
from
49e1397 to
e2b808e
Compare
In Rails 5, the schema layer was updated so that indexes could be created on expressions rather that simply columns. Update `have_db_index` so that you can test for this. More reading: <rails/rails@edc2b77>
mcmire
force-pushed
the
extend-have-db-index
branch
2 times, most recently
from
10666aa to
4e2448d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 5, the schema layer was updated so that indexes could be
created on expressions rather that simply columns. Update
have_db_indexso that you can test for this.More reading: rails/rails@edc2b77
Fixes #945.
Fixes #1207.