Remove Rails 4.2 support

[vsppedro]

I think we don't need this comment:

shoulda-matchers/spec/support/unit/capture.rb

Lines 1 to 4 in 178df49

	module Kernel
	# #capture, #silence_stream, and #silence_stderr are deprecated after Rails
	# 4.2 and will be removed in 5.0, so just override them completely here

But I'm not sure if I should do anything other than remove it.

[mcmire]

@vsppedro I think the method is worth keeping, because we make use of it, but perhaps the comment should be updated so that instead of talking about something that will happen, it talks about something that already did happen?

[vsppedro]

@vsppedro I think the method is worth keeping, because we make use of it, but perhaps the comment should be updated so that instead of talking about something that will happen, it talks about something that already did happen?

Something like this?

shoulda-matchers/spec/support/unit/capture.rb

Lines 1 to 4 in b7bd5e9

	module Kernel
	# #capture, #silence_stream, and #silence_stderr were removed in rails 5.0,
	# but we keep it them here

[mcmire]

@vsppedro Yeah, that works for me.

[vsppedro]

@mcmire, would you like me to change anything else in this PR? Just to make sure if I can merge as it is. 😅

[mcmire]

@vsppedro Yeah, I guess I wasn't sure how you were going about this, but it looks like your plan is just to remove Rails 4.2 from CI in this PR and do cleanup around removing all of the places where we're checking for Rails 4.2 in other PRs, right? If that's the case then this looks good to me.

[vsppedro]

Yes, that is exactly what I'm thinking of doing. Thanks! Merging!