Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ruby 3.2 to the CI matrix. Also updates cache and checkout actions versions. #1536

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Adds Ruby 3.2 to the CI matrix. Also updates cache and checkout actions versions. #1536

merged 1 commit into from
Jan 10, 2023

Conversation

petergoldstein
Copy link
Contributor

To get this running green I needed to:

  1. Revisit gem restrictions for the Rails 7 gemfile, allowing more recent rake versions and setting the rspec-rails version to 6.x, which is appropriate for Rails 7
  2. Exclude byebug if this is Ruby 3.2 or higher

I also updated the bundler version in the Rails 7 gemfile, updated the patch versions of the other Rubies to current, and fixed a deprecated configuration parameter in the Rubocop configuration to eliminate warnings.

Everything runs green on my fork.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
universalmind303 Cory Grinstead
… versions.

To get this working I needed to:

1. Revisit gem restrictions for the Rails 7 gemfile, allowing more recent rake versions and setting the rspec-rails version to 6.x, which is appropriate for Rails 7
2. Exclude byebug if this is Ruby 3.2 or higher

I also updated the bundler version in the Rails 7 gemfile and fixed a deprecated configuration parameter in the Rubocop configuration to eliminate warnings.
@vsppedro vsppedro merged commit 8fc832d into thoughtbot:main Jan 10, 2023
@vsppedro
Copy link
Collaborator

Hi, @petergoldstein, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants