Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds failure_message_when_negated to have_secure_password_matcher #1593

Conversation

amalrik
Copy link
Contributor

@amalrik amalrik commented Dec 20, 2023

closes #1187
credits goes to @Kutomore Im just adding missing specs to his solution on a new PR because I cant override PR #1192

Copy link
Member

@matsales28 matsales28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@vsppedro vsppedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Matheus Dutra Lima <kutomore@gmail.com>
@amalrik amalrik force-pushed the adding-failure-message-to-have_secure_password_matcher branch from c3e2b81 to 4b04a44 Compare December 23, 2023 10:54
@amalrik
Copy link
Contributor Author

amalrik commented Dec 23, 2023

Looks good to me! I believe it would be a great idea to squash the commits and include @Kutomore as a co-author.

https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-github

What do you think?

Good idea. Done

@amalrik amalrik requested a review from vsppedro December 23, 2023 10:55
@vsppedro vsppedro merged commit a373661 into thoughtbot:main Dec 23, 2023
15 checks passed
@vsppedro
Copy link
Collaborator

Thank you for your contribution, @amalrik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

have_secure_password cannot be used in the negative
3 participants