Convert Nav and ApplicationBase to functional components #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jho406
force-pushed
the
hooks-usepage
branch
3 times, most recently
from
657ce23 to
9fc633a
Compare
jho406
force-pushed
the
migrate-to-functional-components
branch
2 times, most recently
from
82356b5 to
c2d2a5e
Compare
This PR is fairly long, but it converts the two components into its functional counterpart. With the `Nav` we converted to `Navigation`that exports a `NavigationProvider` component and a `NavigationContext`, the latter is handy if we wanted to access visit, remote, pageKey, and navigateTo to help users build a custom `<Link>` component or if they want to use the functions without passing it from parent to child. With `Application`, we removed `ApplicationBase`. In doing so, we've simplified the component to the point that if someone wanted fine grain control of building the redux `Provider` or `Navigation`, they can just refer to the source code and build their own using the same helper methods in `lib/index.ts`. We also updated the docs.
jho406
force-pushed
the
migrate-to-functional-components
branch
from
c2d2a5e to
85e50f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fairly long, but it converts the two components into its functional counterpart.
With the
Navwe converted toNavigationthat exports aNavigationProvidercomponent and aNavigationContext, the latter is handy if we wanted to access visit, remote, pageKey, and navigateTo to help users build a custom<Link>component or if they want to use the functions without passing it from parent to child.With
Application, we removedApplicationBase. In doing so, we've simplified the component to the point that if someone wanted fine grain control of building the reduxProviderorNavigation, they can just refer to the source code and build their own using the same helper methods inlib/index.ts.We also updated the docs.