-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce suspenders:ci
generator
#1172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepolitodesign
force-pushed
the
suspenders-3-0-0-ci
branch
4 times, most recently
from
March 23, 2024 15:04
7e84bd8
to
de6e19e
Compare
stevepolitodesign
force-pushed
the
suspenders-3-0-0-ci
branch
2 times, most recently
from
March 23, 2024 15:22
6904b03
to
916c08d
Compare
Creates CI template to be run via [GitHub Actions][ga] based on a [similar template][ci template] that will be generated in an upcoming Release of Rails. Also create a [Dependabot][dependabot] file based off the [the upcoming release][ci template]. Raises if the application is not using PostgreSQL, since our CI template assumes that adapter. Because this generator can be run in an existing application, we add conditional checks for some jobs. However, this generator is intended to be run as part of our holistic `suspenders:install:web` which will be introduced in #1152. Once Rails is released to contain a CI template, we will need to consider how we want to handle conflicts between its file and ours, but for now, we do not need to worry about that. [ga]: https://docs.github.com/en/actions [ci template]: rails/rails#50508 [dependabot]: https://docs.github.com/en/code-security/dependabot/working-with-dependabot
stevepolitodesign
force-pushed
the
suspenders-3-0-0-ci
branch
from
March 23, 2024 15:26
916c08d
to
e65f072
Compare
stevepolitodesign
added a commit
that referenced
this pull request
Mar 23, 2024
Follow-up to #1172 Fixes indentation ensuring a valid syntax. Also fixes linting violations raised by `yarn lint`.
stevepolitodesign
added a commit
that referenced
this pull request
Mar 23, 2024
Follow-up to #1172 Fixes indentation ensuring a valid syntax. Also fixes linting violations raised by `yarn lint`.
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Creates CI template to be run via [GitHub Actions][ga] based on a [similar template][ci template] that will be generated in an upcoming Release of Rails. Also create a [Dependabot][dependabot] file based off the [the upcoming release][ci template]. Raises if the application is not using PostgreSQL, since our CI template assumes that adapter. Because this generator can be run in an existing application, we add conditional checks for some jobs. However, this generator is intended to be run as part of our holistic `suspenders:install:web` which will be introduced in #1152. Once Rails is released to contain a CI template, we will need to consider how we want to handle conflicts between its file and ours, but for now, we do not need to worry about that. [ga]: https://docs.github.com/en/actions [ci template]: rails/rails#50508 [dependabot]: https://docs.github.com/en/code-security/dependabot/working-with-dependabot
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Follow-up to #1172 Fixes indentation ensuring a valid syntax. Also fixes linting violations raised by `yarn lint`.
This was referenced May 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates CI template to be run via GitHub Actions based on a
similar template that will be generated in an upcoming
Release of Rails.
Also create a Dependabot file based off the the upcoming
release.
Raises if the application is not using PostgreSQL, since our CI template
assumes that adapter.
Because this generator can be run in an existing application, we add
conditional checks for some jobs. However, this generator is intended
to be run as part of our holistic
suspenders:install:web
which will beintroduced in #1152.
Once Rails is released to contain a CI template, we will need to
consider how we want to handle conflicts between its file and ours, but
for now, we do not need to worry about that.