Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce suspenders:ci generator #1172

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

stevepolitodesign
Copy link
Contributor

@stevepolitodesign stevepolitodesign commented Mar 22, 2024

Creates CI template to be run via GitHub Actions based on a
similar template that will be generated in an upcoming
Release of Rails.

Also create a Dependabot file based off the the upcoming
release
.

Raises if the application is not using PostgreSQL, since our CI template
assumes that adapter.

Because this generator can be run in an existing application, we add
conditional checks for some jobs. However, this generator is intended
to be run as part of our holistic suspenders:install:web which will be
introduced in #1152.

Once Rails is released to contain a CI template, we will need to
consider how we want to handle conflicts between its file and ours, but
for now, we do not need to worry about that.

README.md Outdated Show resolved Hide resolved
@stevepolitodesign stevepolitodesign force-pushed the suspenders-3-0-0-ci branch 4 times, most recently from 7e84bd8 to de6e19e Compare March 23, 2024 15:04
@stevepolitodesign stevepolitodesign force-pushed the suspenders-3-0-0-ci branch 2 times, most recently from 6904b03 to 916c08d Compare March 23, 2024 15:22
Creates CI template to be run via [GitHub Actions][ga] based on a
[similar template][ci template] that will be generated in an upcoming
Release of Rails.

Also create a [Dependabot][dependabot] file based off the [the upcoming
release][ci template].

Raises if the application is not using PostgreSQL, since our CI template
assumes that adapter.

Because this generator can be run in an existing application, we add
conditional checks for some jobs. However, this generator is intended
to be run as part of our holistic `suspenders:install:web` which will be
introduced in #1152.

Once Rails is released to contain a CI template, we will need to
consider how we want to handle conflicts between its file and ours, but
for now, we do not need to worry about that.

[ga]: https://docs.github.com/en/actions
[ci template]: rails/rails#50508
[dependabot]: https://docs.github.com/en/code-security/dependabot/working-with-dependabot
@stevepolitodesign stevepolitodesign marked this pull request as ready for review March 23, 2024 15:29
@stevepolitodesign stevepolitodesign merged commit 5f90074 into suspenders-3-0-0 Mar 23, 2024
2 checks passed
@stevepolitodesign stevepolitodesign deleted the suspenders-3-0-0-ci branch March 23, 2024 15:29
@stevepolitodesign stevepolitodesign mentioned this pull request Mar 23, 2024
17 tasks
stevepolitodesign added a commit that referenced this pull request Mar 23, 2024
Follow-up to #1172

Fixes indentation ensuring a valid syntax. Also fixes linting violations
raised by `yarn lint`.
stevepolitodesign added a commit that referenced this pull request Mar 23, 2024
Follow-up to #1172

Fixes indentation ensuring a valid syntax. Also fixes linting violations
raised by `yarn lint`.
stevepolitodesign added a commit that referenced this pull request May 10, 2024
Creates CI template to be run via [GitHub Actions][ga] based on a
[similar template][ci template] that will be generated in an upcoming
Release of Rails.

Also create a [Dependabot][dependabot] file based off the [the upcoming
release][ci template].

Raises if the application is not using PostgreSQL, since our CI template
assumes that adapter.

Because this generator can be run in an existing application, we add
conditional checks for some jobs. However, this generator is intended
to be run as part of our holistic `suspenders:install:web` which will be
introduced in #1152.

Once Rails is released to contain a CI template, we will need to
consider how we want to handle conflicts between its file and ours, but
for now, we do not need to worry about that.

[ga]: https://docs.github.com/en/actions
[ci template]: rails/rails#50508
[dependabot]: https://docs.github.com/en/code-security/dependabot/working-with-dependabot
stevepolitodesign added a commit that referenced this pull request May 10, 2024
Follow-up to #1172

Fixes indentation ensuring a valid syntax. Also fixes linting violations
raised by `yarn lint`.
This was referenced May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant