Remove posix runner and unsupported posix-spawn gem #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-penguin
approved these changes
Feb 9, 2023
|
Oh dang looks like you are already on it #16 |
|
Ahhh that was all @joshuaclayton!!! But yea it's done, wanted to put it in a separate PR though since it's such a big change. |
jutonz
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Awesome, I love it! This is so much cleaner. I wonder if we could even just remove BackticksRunner at some point too, since Process.spawn should be available on all currently supported rubies.
I just had one small note about the Runners section of the readme, but other than that this looks great! And since this gem isn't 1.0 yet we don't have to worry about making a breaking change. Great work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Terrapin's PosixRunner, which relies on the now unsupported posix-spawn gem. Improvements to Ruby (as of Ruby 3.0) means that
posix-spawnis now less performant than native Ruby implementation. You can read more about this in this posix-spawn issue, specifically this comment.We feel it's no longer necessary to provide posix support as there are no longer advantages over native. Since Ruby 2.x will no longer be supported soon, it's important that we maintain Terrapin to be compatible with the lowest supported version of Ruby.