Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to extract/query for reconcilation report results #13

Closed
chadlwilson opened this issue Oct 1, 2021 · 2 comments
Closed

Ability to extract/query for reconcilation report results #13

chadlwilson opened this issue Oct 1, 2021 · 2 comments
Assignees
@chadlwilson
Labels
enhancement New feature or request size:M medium items

Comments

@chadlwilson
Copy link
Collaborator

chadlwilson commented Oct 1, 2021 •
edited
Loading

Context / Goal

In #12 we persisted the results of the reconciliation run, but we probably need an easy way for them to be extracted via an API.

Expected Outcome

  • Find results by migration run id?
  • Find results by dataset name
    • filter by time period?

Out of Scope

Additional context / implementation notes

  • via API?
  • summaries? details?
  • how does it complement what was logged?
  • some kind of simple web UI?
@chadlwilson chadlwilson added the enhancement New feature or request label Oct 1, 2021
@chadlwilson chadlwilson mentioned this issue Oct 25, 2021
Closed
@chadlwilson chadlwilson mentioned this issue Nov 5, 2021
Open
chadlwilson added a commit that referenced this issue Nov 5, 2021
@chadlwilson
#13 Add ability to retrieve an individual run's details via the API
f2cffc5
chadlwilson added a commit that referenced this issue Nov 5, 2021
@chadlwilson
#13 Add ability to retrieve runs by the dataset ID
ff1c1ab 
Currently limits to the last 10 completed runs.
chadlwilson added a commit that referenced this issue Nov 5, 2021
@chadlwilson
#13 Add index on dataset_id
914d686 
Also renamed the bad default index names (for Postgres)
@chadlwilson
Copy link
Collaborator Author

chadlwilson commented Nov 5, 2021 •
edited
Loading

  • Find results by migration run id?
  • Find results by dataset name

@chadlwilson chadlwilson self-assigned this Nov 5, 2021
chadlwilson added a commit that referenced this issue Nov 5, 2021
@chadlwilson
#13 Minor cleanups in DatasetRecRunController
3320d99
chadlwilson added a commit that referenced this issue Nov 8, 2021
@chadlwilson
#13 Improve logging of API calls
b58e78a
chadlwilson added a commit that referenced this issue Nov 8, 2021
@chadlwilson
#13 Correct return of runs that never completed from query API
57e97f7
chadlwilson added a commit that referenced this issue Nov 8, 2021
@chadlwilson
#13 Add some quick start details in the absence of API docs for now
3d25ac5
@chadlwilson chadlwilson added the size:M medium items label Nov 9, 2021
@chadlwilson chadlwilson mentioned this issue Nov 10, 2021
Closed
@chadlwilson
Copy link
Collaborator Author

Carved out returning the detailed results into #58 as this requires more thought. Also will await more feedback before implementing a filter by time period. Need to drive some of this stuff from user demand.

chadlwilson added a commit that referenced this issue Nov 10, 2021
@chadlwilson
#13 Ensure the datasetId isn't blank
6adf318
chadlwilson added a commit that referenced this issue Nov 10, 2021
@chadlwilson
#13 Ensure the datasetId isn't blank
f10c9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadlwilson chadlwilson

Labels
enhancement New feature or request size:M medium items
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chadlwilson