Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to build and push a runnable Docker image to a repository #5

Closed
chadlwilson opened this issue Oct 1, 2021 · 1 comment
Closed
Assignees
Labels
build-scripts Build and release engineering size:M medium items task General technical task

Comments

@chadlwilson
Copy link
Collaborator

chadlwilson commented Oct 1, 2021

Context / Goal

To make it

  • easier to use Recce
  • gain some initial feedback
  • not have to build from source

...we really need to build and push a Docker image to an external Docker repository.

However currently we don't have the necessary clearance to push this openly, so we should start by exploring whether we can push to a private repository where we can grant folks access.

Expected Outcome

  • Suggested by @flosell that we might be able to push to GHCR and manage access via GH credentials in the interim. Explore this and integrate it if it works.
  • Change the GH actions build to push to GHCR
  • Add/document a mechanism to run against a pushed image by version locally

Out of Scope

  • Pushing to a public repository open to anyone

Additional context / implementation notes

@chadlwilson chadlwilson added the build-scripts Build and release engineering label Oct 1, 2021
@chadlwilson chadlwilson added the task General technical task label Oct 4, 2021
@chadlwilson chadlwilson added the size:M medium items label Nov 10, 2021
@chadlwilson chadlwilson self-assigned this Nov 10, 2021
chadlwilson added a commit that referenced this issue Nov 10, 2021
Currently only building latest versions of images; can worry about proper versioning later.
chadlwilson added a commit that referenced this issue Nov 10, 2021
…sed correctly

By default jib only depends on building the production classes; so will start pushing in parallel even if tests fail.
chadlwilson added a commit that referenced this issue Nov 10, 2021
Since we have pre-built official images, we should distinguish them from those that are locally built
chadlwilson added a commit that referenced this issue Nov 10, 2021
@chadlwilson
Copy link
Collaborator Author

This is now done.

Can be followed up on by

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-scripts Build and release engineering size:M medium items task General technical task
Projects
None yet
Development

No branches or pull requests

1 participant