Patch bug with return value in functions in prompt templates#1
Merged
gtang31-te merged 2 commits intothousandeyes:thousandeyes-fixesfrom Mar 3, 2025
skarygia-te:main
Merged
Patch bug with return value in functions in prompt templates#1gtang31-te merged 2 commits intothousandeyes:thousandeyes-fixesfrom skarygia-te:main
gtang31-te merged 2 commits intothousandeyes:thousandeyes-fixesfrom
skarygia-te:main
Conversation
gtang31-te
merged commit 0012b19
into
thousandeyes:thousandeyes-fixes
13 of 26 checks passed
jcruzmot-te
pushed a commit
that referenced
this pull request
Aug 20, 2025
jcruzmot-te
pushed a commit
that referenced
this pull request
Sep 15, 2025
jcruzmot-te
pushed a commit
that referenced
this pull request
Nov 17, 2025
Patch bug with return value in functions in prompt templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes a bug with the returned result in case of an internal function call in a prompt template function. Open issue: microsoft#10676
Description
In the template_engine folder, the function the renders an internal function call has a bug. In case the result is a FunctionResult, str(result) does not propagate the correct values. Instead a str(result.value) needs to be performed.
Contribution Checklist