Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new hooks #30

Closed
wants to merge 1 commit into from
Closed

added new hooks #30

wants to merge 1 commit into from

Conversation

volkan
Copy link

@volkan volkan commented Jan 1, 2016

No description provided.

@thp
Copy link
Owner

thp commented Jan 1, 2016

Please do not check in the *.pyc bytecode files.

@thp
Copy link
Owner

thp commented Jan 1, 2016

Also, please provide a description what your change does and what the goal of the change is - i.e. what use cases there are for using those features that you add.

@volkan
Copy link
Author

volkan commented Jan 2, 2016

Sorry for pyc files. I fixed it.

1.diff_after_hook which is used when the difference appears. For cache invalidation like varnish or other tools.
2.request_hook is used to customize main request or to add the process of a new request. Like login process.

@thp
Copy link
Owner

thp commented Jan 6, 2016

For the "PURGE" (request hook) requests, maybe that could be a new job type after #32 has been merged? Also, on top of #32 we could probably make the hooks a bit nicer in general (or also make a login job type that then calls some hooks).

@volkan
Copy link
Author

volkan commented Jan 6, 2016

It sounds good.

@thp
Copy link
Owner

thp commented Jan 7, 2016

These changes have now been merged. For a simple change in HTTP method, you can now just specify method: PURGE in the YAML file. For logins, you can define a new job type that handles the login. I have added corresponding examples to urls.yaml.example and hooks.py.example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants