-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a uniq filter. #653
Add a uniq filter. #653
Conversation
@thp wdyt? (Draft as I didn't add docs, if you'll ok this I'll add them and un-draft) |
The reason why The reason why your So for line-based uniqueness, I think it's fine to just sort it first (try What might be interesting is a kind of "unique / sort" kind of filter that works on e.g. CSS or XPath selectors, as this is kind of hard to do with built-in unix commands. Feel free to turn this PR into a documentation change that shows how to use shellpipe + |
@thp thanks for answering. You might be right that I didn't play with In this case, I think my implementation of Is this use case still not interesting enough to be merged? |
Yeah I think it's valid, but rename it |
@thp updated the name as per your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, rest looks good already. The optional separator
subfilter option should also be documented.
@thp made the changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
Changes made. |
Please mark as ready for review + update changelog + squash to a single commit and then we can merge this. |
0907d21
to
032cc0e
Compare
032cc0e
to
38344a3
Compare
@thp done. |
No description provided.