Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for sending to multiple recipients via sendmail #797

Merged
merged 7 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The format mostly follows [Keep a Changelog](http://keepachangelog.com/en/1.0.0/

### Fixed

- Fix multiple recipients for sendmail reporter (#797)
monperrus marked this conversation as resolved.
Show resolved Hide resolved
- Fix documentation for watching Github tags and releases, again (#723)
- Fix `--test-reporter` command-line option so `separate` configuration option is no longer ignored when sending test notifications (#772, by marunjar)
- Fix line height and dark mode regression (#774 reported by kongomongo, PRs #777 and #778 by trevorshannon)
Expand Down
1 change: 1 addition & 0 deletions docs/source/reporters.rst
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ At the moment, the following reporters are built-in:
- **prowl**: Send a detailed notification via prowlapp.com
- **pushbullet**: Send summary via pushbullet.com
- **pushover**: Send summary via pushover.net
- **sendmail**: Pipe a message to the system sendmail command
thp marked this conversation as resolved.
Show resolved Hide resolved
- **shell**: Pipe a message to a shell command
- **slack**: Send a message to a Slack channel
- **stdout**: Print summary on stdout (the console)
Expand Down
2 changes: 1 addition & 1 deletion lib/urlwatch/mailer.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def __init__(self, sendmail_path):
self.sendmail_path = sendmail_path

def send(self, msg):
p = subprocess.Popen([self.sendmail_path, '-oi', '-f', msg['From'], msg['To']],
p = subprocess.Popen([self.sendmail_path, '-oi', '-f', msg['From']] + msg['To'].split(','),
stdin=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True)
Expand Down
Loading