Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Version2 - AssetEnabled #1673

Closed
wants to merge 6 commits into from

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Oct 10, 2024

This PR moves the AssetEnabled upgrade into a Versioned upgrade, and as a result can remove all the bool pointer logic.
It also upgrades the example and test config to Version2.

Dependencies

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested

  • go test ./... -race
  • golangci-lint run

@gbjk gbjk force-pushed the feature/config_v2 branch from d0258b3 to 6d71d93 Compare October 10, 2024 09:36
@shazbert shazbert added the nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged label Oct 11, 2024
@shazbert shazbert requested a review from a team October 11, 2024 00:21
@gbjk
Copy link
Collaborator Author

gbjk commented Oct 12, 2024

Rejigging naming. Will reopen

@gbjk gbjk closed this Oct 12, 2024
@gbjk gbjk deleted the feature/config_v2 branch October 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nomerge requires dependency This pull request is dependent on another, so it can't be merged until the dependent one is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants