Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huobi: Fix GetAvailableTransferChains returning unavailable chains #1709

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

gbjk
Copy link
Collaborator

@gbjk gbjk commented Nov 9, 2024

Fixes:
[ERROR] | LOG | 08/11/2024 19:39:52 | Huobi failed to get cryptocurrency deposit address for BTC [chain hrc20btc]. Err: unable to match deposit address currency or chain

This seems sufficient, though I'm unhappy with the way that GetAvailableTransferChains might return a withdraw only chain.
Reality right now is that Huobi has no "deposit not allowed" chains which are also "withdraw allowed", so this isn't currently an issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested

  • go test ./... -race
  • golangci-lint run

@gbjk gbjk added the bug label Nov 9, 2024
@gbjk gbjk self-assigned this Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.04%. Comparing base (8fe909d) to head (7ec1036).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
exchanges/huobi/huobi_wrapper.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1709      +/-   ##
==========================================
+ Coverage   36.95%   37.04%   +0.09%     
==========================================
  Files         414      414              
  Lines      180443   180308     -135     
==========================================
+ Hits        66677    66799     +122     
+ Misses     105923   105665     -258     
- Partials     7843     7844       +1     
Files with missing lines Coverage Δ
exchanges/huobi/huobi_wrapper.go 39.74% <80.00%> (+0.08%) ⬆️

... and 20 files with indirect coverage changes

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. tACK!

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ch ACK.

Copy link
Collaborator

@thrasher- thrasher- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🚀

$ ./gctcli getavailabletransferchains huobi BTC
{
 "chains": [
  "btc",
  "trc20btc"
 ]
}
$ ./gctcli getcryptocurrencydepositaddresses huobi
{
 "addresses": {
  "BTC": {
   "addresses": [
    {
     "address": "x",
     "chain": "btc"
    },
    {
     "address": "y",
     "chain": "trc20btc"
    }
   ]
  },
  "USDT": {
   "addresses": [

@thrasher- thrasher- merged commit fb0fd2e into thrasher-corp:master Nov 11, 2024
9 of 13 checks passed
@gbjk gbjk deleted the bugfix/huobi_deposit_addr🐍 branch November 11, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants