Travis #3
Merged
Travis #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit summary made me laaauuuuugh hahahah
…On Thu, Dec 1, 2016 at 3:21 PM, Gleb Mazovetskiy ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- Support PostGIS adapters. Fixes #2
- Changelog
- Travis: no need to install mysql
- mysql no password?
- mysql not in whitelist for trusty docker
- matrix doesnt allow mixing strings with hashes
- matrix include
- fix matrix
- ugh
- f
- wat
- user?
- user2?
- f
- ugh 5.6
File Changes
- *M* .travis.setup.sh
<https://github.com/thredded/db_text_search/pull/3/files#diff-0> (6)
- *M* .travis.yml
<https://github.com/thredded/db_text_search/pull/3/files#diff-1> (14)
- *M* CHANGES.md
<https://github.com/thredded/db_text_search/pull/3/files#diff-2> (5)
- *M* lib/db_text_search.rb
<https://github.com/thredded/db_text_search/pull/3/files#diff-3> (2)
- *M* script/create-db-users
<https://github.com/thredded/db_text_search/pull/3/files#diff-4> (5)
- *M* spec/db_text_search/case_insensitive_spec.rb
<https://github.com/thredded/db_text_search/pull/3/files#diff-5> (4)
Patch Links:
- https://github.com/thredded/db_text_search/pull/3.patch
- https://github.com/thredded/db_text_search/pull/3.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABuIra6u9kl1enHhrU598zmEGDo25moks5rDyxfgaJpZM4LB2O3>
.
|
|
Travis takes 5 years to add MySQL v5.6 (but not to to the container distro) and botches the root user setup (travis-ci/travis-ci#6961). Don't be like Travis. 😅 Trying it out with any Rails + MySQL app before doing a release would've caught this. |
|
So this begs the question - maybe time to try out circleci/codeship/etc for
some OSS stuff?
…On Thu, Dec 1, 2016 at 3:36 PM, Gleb Mazovetskiy ***@***.***> wrote:
Travis takes 5 years to add MySQL v5.6 (but not to to the container
distro) and botches the root user setup (travis-ci/travis-ci#6961
<travis-ci/travis-ci#6961>). Don't be like
Travis. 😅
Trying it out with any Rails + MySQL app before doing a release would've
caught this.
Good faith limit exceeded.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABuIghCW6j1htgpF_h563zJKZOZodYhks5rDy_agaJpZM4LB2O3>
.
|
|
Yes, definitely, the next time travis breaks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.