New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternion.fromArray() doesn't allow arbitrary length arrays #1229

Closed

mattrossman opened this issue Sep 18, 2024 · 0 comments · Fixed by #1230

Contributor

mattrossman commented Sep 18, 2024

From thread #426 (comment)

Similarly, toArray has a quirk where it suggests a QuaternionTuple return type which isn't always the case.

Just filing an issue for this so I can follow the CONTRIBUTING branch naming guidelines.

I'll submit a PR to align the fromArray and toArray types for Quaternion with how it's written for Vector3.

mattrossman mentioned this issue

fix: Quaternion fromArray and toArray signatures #1230

Merged

Methuselah96 closed this as completed in #1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment