Three json #426
Merged
Three json #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addding a Skeleton.toJSON
JSON data for BufferAttribute
|
@Methuselah96 What do you think of the progress so far? |
…cally. Prefer to explicitly write 'export' for clarity. If you have a good reason not to export this declaration, add 'export {}' to the module to shut off automatic exporting @definitelytyped/strict-export-declare-modifier
Methuselah96
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
@Hoodgail Thanks for your work on this! I went ahead and did some cleanup of some of the changes, hopefully while preserving the intent of your changes. Let me know if I messed anything up and feel free to keep building on this with more PRs, I just figured this would be a good place to get some of it merged.
|
Thank you |
Hoodgail
added a commit
to Hoodgail/three-ts-types
that referenced
this pull request
Jul 17, 2024
Introduces the MaterialJSON format in Three.js, which extends the Material interface. The new format includes serializable properties such as color, roughness, metallic, map, normalMap, and many more. This change enables better JSON parsing and handling of material configurations for Three.js applications. Confirmed: Types and interfaces have been updated in Object3D.d.ts and Material.d.ts. The Material class has also been updated to include toJSON methods that return MaterialJSON or MaterialJSONRoot objects based on the provided meta data. Reference(s): three-types#1071 three-types#1070 three-types#426
Methuselah96
added a commit
that referenced
this pull request
Jul 18, 2024
* Update Material type definitions: Add MaterialJSON format Introduces the MaterialJSON format in Three.js, which extends the Material interface. The new format includes serializable properties such as color, roughness, metallic, map, normalMap, and many more. This change enables better JSON parsing and handling of material configurations for Three.js applications. Confirmed: Types and interfaces have been updated in Object3D.d.ts and Material.d.ts. The Material class has also been updated to include toJSON methods that return MaterialJSON or MaterialJSONRoot objects based on the provided meta data. Reference(s): #1071 #1070 #426 * Fix: Error: 240:16 error Array type using 'T[]' is forbidden for non-simple types. Use 'Array<T>' instead @typescript-eslint/array-type * ShaderMaterial & Fixes * Add ShaderMaterialJSON to JSONMeta.materials record * Fixes Error: 105:28 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 136:19 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 157:22 error Array type using 'Array<number>' is forbidden for simple types. Use 'number[]' instead @typescript-eslint/array-type Error: 242:14 error Array type using 'Array<SourceJSON>' is forbidden for simple types. Use 'SourceJSON[]' instead @typescript-eslint/array-type * Error: 240:16 error Array type using 'T[]' is forbidden for non-simple types. Use 'Array<T>' instead @typescript-eslint/array-type * Material * ShaderMaterial * Object3D --------- Co-authored-by: Nathan Bierema <nbierema@gmail.com>
|
@Hoodgail I traced this PR as the source of the Since fromArray(array: QuaternionTuple, offset?: number): this;it produces an error when provided an array that doesn't strictly have 4 elements, which is expected when passing an
Is there a reason |
|
@mattrossman It looks like this was an oversight on my part. I had completely forgot about the offset argument It should follow the same way its written in Vector3 at 
Will you make a pull request? or should i? My apologies ! |
mattrossman
added a commit
to mattrossman/three-ts-types
that referenced
this pull request
Sep 18, 2024
Updates the Quaternion overloads for fromArray and toArray to align with Vector3's implementation as discussed here: three-types#426 (comment)
Methuselah96
pushed a commit
that referenced
this pull request
Sep 18, 2024
* fix: Quaternion fromArray and toArray signatures Updates the Quaternion overloads for fromArray and toArray to align with Vector3's implementation as discussed here: #426 (comment) * fix: Return number[] for number[] input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object3D
FogBase
Math
(Core)Texture
Source
BufferGeometry
BufferAttribute
KeyframeTrack
Finalization