change: Added Vector3.setFromEuler(); removed Euler.toVector3() #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
requested changes
Mar 1, 2022
|
|
||
| /** | ||
| * @deprecated .toVector3() has been removed. Use {@link Vector3.setFromEuler Vector3.setFromEuler()} instead | ||
| */ | ||
| toVector3(optionalResult?: Vector3): Vector3; |
There was a problem hiding this comment.
If they've removed it from the source, we should remove it here.
|
closed in favour of b1f8b5f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To catch up with r138
What
See: mrdoob/three.js#23494
Vector3.setFromEulerEuler.toVector3deprecatedPoints need review
Euler.toVector3actually does not fallback to the newVector3.setFromEuler(code). Is this okay to mark this be deprecated or should I remove the signature instead?Checklist
master, next goesdev)